Skip to content

Fixing the static-linking.#547

Merged
Narsil merged 5 commits intomainfrom
fix_static_linking
Mar 29, 2025
Merged

Fixing the static-linking.#547
Narsil merged 5 commits intomainfrom
fix_static_linking

Conversation

@Narsil
Copy link
Contributor

@Narsil Narsil commented Mar 29, 2025

What does this PR do?

Fixes # (issue)

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@Narsil Narsil merged commit 943be86 into main Mar 29, 2025
14 checks passed
@Narsil Narsil deleted the fix_static_linking branch March 29, 2025 12:16
Comment on lines +10 to +15
// const KERNEL_FILES: [&str; 4] = [
// "flash_api.cu",
// "fmha_fwd_hdim32.cu",
// "fmha_fwd_hdim64.cu",
// "fmha_fwd_hdim128.cu",
// ];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this intended?

@@ -23,8 +23,8 @@ fn main() -> Result<()> {
for kernel_file in KERNEL_FILES.iter() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no read dir here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants